chore: Rename variables chat_model to chat_client
#1927
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR renames the variable "chat_model" to "chat_client" across several files for improved clarity and consistency.
- Updated variable name in model initialization and usage across multiple language model integrations.
- Standardized the return value and async function references to use "chat_client".
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shiny/templates/chat/llms/playground/app.py | Renamed variable in model creation and return statement. |
| shiny/templates/chat/llms/ollama/app.py | Updated variable references in initialization and async callback. |
| shiny/templates/chat/llm-enterprise/aws-bedrock-anthropic/app.py | Replaced variable name in initialization and async handler. |
| shiny/templates/chat/llms/anthropic/app.py | Renamed variable and updated its async usage. |
| shiny/templates/chat/llm-enterprise/azure-openai/app.py | Changed variable name in initialization and async callback. |
| shiny/templates/chat/llms/langchain/app.py | Updated variable name in both initialization and async handling. |
| shiny/templates/chat/llms/google/app.py | Renamed variable in initialization and async function. |
| shiny/templates/chat/llms/openai/app.py | Changed variable name in initialization and async callback. |
|
I don't love this change for 2 reasons:
https://python.langchain.com/v0.1/docs/modules/model_io/chat/ |
I think the risk of confusion about which is the "client" is so much smaller compared to "model". AFAIK, we don't use client to talk about
|
I'm not sure I follow. Are you saying |
Oh sorry, no, not specifically the |
No description provided.